[CLEANUP] Avoid multiline strings in CommentTest - #1428
Merged
Conversation
JakeQZ
approved these changes
Dec 14, 2025
JakeQZ
left a comment
Collaborator
There was a problem hiding this comment.
Looks like painstaking work - unless you have anything in your IDE to help.
These strings can't be changed, e.g. by indenting them like
$expected1 = '
a {
color: green;
}
';... (which would be more readable) because they need to be exact.
I don't believe there is a CodeSniffer or CS-Fixer rule that would do the job (the closest I found squizlabs/PHP_CodeSniffer#1557 which would change the content of the strings).
My IDE (I think) is set to convert tabs to spaces upon save (and I'm pretty sure does it blindly), so if I edited that file I'd have broken the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.